[MPlayer-cvslog] r29123 - trunk/libmpdemux/parse_mp4.c

[Uoti Urpala]

On Thu, 2009-04-02 at 00:39 +0200, Diego Biurrun wrote:
> On Thu, Apr 02, 2009 at 01:32:48AM +0300, Uoti Urpala wrote:
> > On Thu, 2009-04-02 at 00:20 +0200, Diego Biurrun wrote:
> > > On Thu, Apr 02, 2009 at 01:15:22AM +0300, Uoti Urpala wrote:
> > > > but I meant "in case HAVE_MALLOC_H was not defined". In other words I
> > > > see no reason why that check would ever need to _succeed_.
> > > 
> > > If it's undefined we get a warning, if it's defined to 0, the header is
> > > skipped, if it's defined to 1, the header is included.  We have the
> > > desired behavior now.
> > 
> > And the advantage over deleting the whole #ifdef stuff is? Is there
> > anything that actually needs it?
> 
> malloc.h is not a standard header.

Yes, but if your only concern about the variable always being undefined
is compiler warnings about the #if itself, then why do you need the test
at all? You can fix those compiler warnings by deleting the whole thing
- it can't produce warnings then, and if those warnings were the only
problem with the code always behaving the same on every platform then
there should be no need for any platform-dependent #ifs.