[MPlayer-cvslog] r26914 - in trunk: DOCS/xml/en/video.xml Makefile drivers/Makefile

[Rich Felker]

On Wed, Sep 10, 2008 at 06:17:03PM +0200, Diego Biurrun wrote:
> On Wed, Sep 10, 2008 at 05:35:11PM +0200, Attila Kinali wrote:
> > On Wed, 28 May 2008 14:40:15 +0200 (CEST)
> > diego <subversion at mplayerhq.hu> wrote:
> > 
> > > Log:
> > > Merge drivers/Makefile into top-level Makefile.
> > 
> > Is there any sane reason to merge the drivers Makefile into the top
> > level Makefile? If so, could you please elaborate it?
> 
> There is absolutely no reason to keep it separate.  If you look at the
> diffs you will see that some refactoring was possible due to this
> change.
> 
> > If not, i would like to ask you to revert this change as it makes
> > building the drivers a black magic that is not obvious even to the
> > seasoned developer.
> 
> Just run any of
> 
> make drivers
> make install-drivers
> make drivers/tdfx_vid.o
> 
> depending on what you need.  How hard can that be?
> 
> And the build system will keep using a monolithic Makefile as long as I
> keep maintaining it, that decision is final.

I have a mixed opinion on this. I've of course always supported the
monolithic makefile, but drivers/ is not part of the MPlayer build.
It's separate linux-specific drivers that just happen to be included
in the MPlayer repo for convenience and historical reasons. There's no
reason one would build these as part of building MPlayer, or vice
versa.

Also, the reason the whole issue came up was that I could not find a
way to build the new mga_vid.o with the Makefile missing from drivers.
It took a good deal of investigation with Attila's help before we
realized what had happened. If the Makefile is not separated back out,
there should be clear build instructions in the drivers directory so
that someone needing to build them can quickly figure out how.

Rich