[MPlayer-cvslog] r27526 - trunk/mpcommon.c

[Aurelien Jacobs]

Ivan Kalvachev wrote:

> On 9/5/08, Aurelien Jacobs <aurel at gnuage.org> wrote:
> > Uoti Urpala wrote:
> >
> >> On Fri, 2008-09-05 at 01:36 +0200, aurel wrote:
> >> > Author: aurel
> >> > Date: Fri Sep  5 01:36:17 2008
> >> > New Revision: 27526
> >> >
> >> > Log:
> >> > a valid ASS line contains 9 ',' before actual text
> >>
> >> With your changes to FFmpeg and MPlayer you've now broken subtitles with
> >> -ass (when using lavf demuxer)
> >
> > Patch fixing this is waiting for review...
> >
> >> and without -ass (when using native demuxer).
> >
> > I think it's not worth fixing old, deprecated demuxer. If you want to
> > fix it, feel free. Or with enough pestering, you might even get me
> > fixing it...
> 
> Please revert this commit and apply it again when:

Reverting this commit now, would only break some cases and not fix
anything, so I doubt it would be a good idea to revert now.

> 1. your libass patch is accepted and committed.

This commit is not related to libass at all. It is required whether
the libass change is applied or not.

> 2. you fix native mkv demuxer, that is still working better in a
> number of cases.

Native mkv demuxer fixed.

Aurel