[MPlayer-cvslog] r27849 - trunk/libvo/x11_common.c

[Uoti Urpala]

On Fri, 2008-10-31 at 17:34 +0300, Andrew Savchenko wrote:
> On Friday 31 October 2008 07:32, Uoti Urpala wrote:
> > I've only seen evidence that it's harmful in some cases and makes 
> > no difference in others.
> 
> It is harmful only for newer versions of xorg >= 1.5.0. We have not 
> enough creditable data to talk about its usefullness or 
> uselessness for older versions. Due to this fact I argue to leave 
> things as is for old versions for safety measures and change it 
> only for new versions of X server. IOW my proposition is just to 
> add an appropriate configure check and #ifdef closure. I do not 
> propose to remove this at all.

That's a really bad idea IMO. A version check would make the code more
complex and harder to maintain (especially so when there would be no
indication why or even if the complexity is needed), and the behavior of
MPlayer would vary more depending on platform.

If some problem does turn up it can be fixed after it occurs, with clear
documentation of exactly _why_ some workaround is needed so the code can
be maintained later without needing to keep something "just in case it
was useful for something".