[MPlayer-cvslog] r27822 - trunk/libmpcodecs/vf_palette.c

[Diego Biurrun]

On Mon, Oct 27, 2008 at 01:21:08PM +0100, Michael Niedermayer wrote:
> On Sun, Oct 26, 2008 at 02:19:30PM +0200, Uoti Urpala wrote:
> > On Sun, 2008-10-26 at 12:54 +0100, Michael Niedermayer wrote:
> > > On Sat, Oct 25, 2008 at 02:07:59AM +0200, uau wrote:
> > > > vf_palette: Fix compilation after libswscale API changes
> > > > 
> > > > Patch from Guillaume Poirier. 
> > > 
> > > > I didn't test the functionality of the
> > > > filter but at least it fixes compilation.
> > > 
> > > right, dont bother, just commit the first best change that makes things
> > > compile. Who needs working code anyway ...
> > 
> > Making the whole MPlayer compile is a lot more important than the
> > functionality of a little used filter. Even if it it was known _not_ to
> > work correctly fixing compilation would still take priority.
> 
> i agree but why in gods f* sake could you not simply have attempted to
> asked/waited for someone who knows the code?

Compilation was already broken for 2 days I think.  So IMO anything
that fixes compilation is better than leaving compilation broken.
Whether disabling the code is preferable can be debated.

> > Feel free to test the functionality of the filter as much as you like.
> > My actions were still better than those of any developer who left
> > compilation broken, which includes you. So your flaming is misguided.
> 
> Sorry but i was not aware of the swscale change breaking compilation
> before i saw your commit. Had you attempted to contact me or waited until
> ive read mplayer-dev i would have fixed it properly.

Well, maybe you can tell us if this filter still makes any sense or
should just be removed.

If you want to fix things properly, there is a patch for vf_smartblur on
dev-eng.  It's one of your filters and it is currently broken.

Diego