[MPlayer-cvslog] r27759 - trunk/stream/cache2.c

[Uoti Urpala]

On Mon, 2008-10-13 at 22:53 +0200, Diego Biurrun wrote:
> On Mon, Oct 13, 2008 at 06:38:00PM +0200, Reimar Döffinger wrote:
> > Hell no! You can't just remove the WINAPI without risking hell to break
> > loose (i.e. crashes). And yes the Windows ThreadProc does have a return
> > value, we wer just missing the return statement.
> 
> I guess the root problem is that we are missing some header then?  Why
> do we need the forward declaration?

The function is not referenced by name outside cache2.c so there is no
prototype for it in any header. But cache2.c gives a pointer to the
function as a parameter to another function, so the interface has to
match what that other function expects.

Did you not get a "incompatible pointer type" warning after this change?
(Assuming you tried it on Windows - the original warning you tried to
remove should only have occurred on Windows and OS/2.)