[MPlayer-cvslog] r27760 - trunk/loader/com.h

Diego Biurrun diego at biurrun.de
Mon Oct 13 20:06:51 CEST 2008


On Mon, Oct 13, 2008 at 07:37:14PM +0200, Reimar Döffinger wrote:
> On Mon, Oct 13, 2008 at 07:27:54PM +0200, Diego Biurrun wrote:
> > On Mon, Oct 13, 2008 at 06:39:38PM +0200, Reimar Döffinger wrote:
> > > On Mon, Oct 13, 2008 at 06:06:15PM +0200, diego wrote:
> > > > 
> > > > Log:
> > > > Remove pointless #ifdef around the whole file.
> > > 
> > > Hm, did you test it actually is pointless? Probably some stuff clashes
> > > with what the Windows headers declare...
> > 
> > Let's see:
> > 
> >   #if !defined(WIN32) || defined(__CYGWIN__) || defined(__MINGW32__)
> > 
> > WIN32 was a shorthand for __CYGWIN__ and __MINGW32__, so the whole
> > condition amounts to a complicated way of saying '#if 1'.
> 
> You could have said that it is pointless because it is always true in
> the commit message.

You are right, fixed.

> See, I will always find a reason why it is your fault ;-)

Haha :)

Diego



More information about the MPlayer-cvslog mailing list