[MPlayer-cvslog] r27707 - trunk/configure

Ivan Kalvachev ikalvachev at gmail.com
Sat Oct 4 18:20:37 CEST 2008


On 10/4/08, diego <subversion at mplayerhq.hu> wrote:
> Author: diego
> Date: Sat Oct  4 13:47:00 2008
> New Revision: 27707
>
> Log:
> Do not duplicate likely/unlikely #defines from libmpeg2/libavcodec in
> config.h.
>
>
> Modified:
>    trunk/configure
>
> Modified: trunk/configure
> ==============================================================================
> --- trunk/configure	(original)
> +++ trunk/configure	Sat Oct  4 13:47:00 2008
> @@ -8033,13 +8033,6 @@ $_def_restrict_keyword
>
>  /* __builtin_expect branch prediction hint */
>  $_def_builtin_expect
> -#ifdef HAVE_BUILTIN_EXPECT
> -#define likely(x) __builtin_expect ((x) != 0, 1)
> -#define unlikely(x) __builtin_expect ((x) != 0, 0)
> -#else
> -#define likely(x) (x)
> -#define unlikely(x) (x)
> -#endif
>

I bet you never run test compile with this patch.
It breaks compilation.

I've complained from your habit to commit untested code before.
It is sad that you put so much effort in perfecting spelling and grammar
and still you are so careless toward the really important stuff.



More information about the MPlayer-cvslog mailing list