[MPlayer-cvslog] r27849 - trunk/libvo/x11_common.c

[Uoti Urpala]

On Sun, 2008-11-09 at 13:41 +0100, Reimar Döffinger wrote:
> On Sun, Nov 09, 2008 at 02:02:23PM +0200, Uoti Urpala wrote:
> > On Sat, 2008-11-08 at 15:03 +0100, Reimar Döffinger wrote:
> > > On Wed, Oct 29, 2008 at 11:03:39PM +0100, ben wrote:
> > > > Log:
> > > > Remove X11 backing store: this is now a useless flag.
> > 
> > > Just not responding is not acceptable, even if it involves a bit of
> > > flaming. In my last mail I have asked for clarification about a few
> > > things in that commit message, if you do not answer them or someone else
> > > volunteers to improve the commit message I will revert within a few
> > > days.
> > 
> > I agree that the commit message did not explain the rationale well.
> > However I do not consider a revert to be an appropriate "solution" to
> > that. IMO doing a revert would have no positive effects whatsoever while
> > it would have negative effects (as far as I can tell not using backing
> > store has a higher chance of working).
> 
> I has the advantage that we may get proper bug reports which allows
> recommitting with a proper commit message. That's all that is to it.

The link I posted earlier had as good a description of one problem case
as any bugreport you're going to get (in short, xserver 1.5.0 implements
backing store the same way as composite and it triggers the same
problems that non-vsync-aware compositing managers have had).

Also enabling backing store requires more justification than leaving it
disabled, and the old change turning it on was no better documented.