[MPlayer-cvslog] r26938 - in trunk/stream: stream_dvd.h stream_dvd_common.c stream_dvd_common.h

[Dominik 'Rathann' Mierzejewski]

On Saturday, 31 May 2008 at 17:28, Diego Biurrun wrote:
> On Sat, May 31, 2008 at 05:25:36PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > On Saturday, 31 May 2008 at 16:13, Diego Biurrun wrote:
> > > On Sat, May 31, 2008 at 02:52:55PM +0200, nicodvb wrote:
> > > > 
> > > > Log:
> > > > adapted to the dvdread->libdvdread transition in dvdnav's repository
> > > > 
> > > > --- trunk/stream/stream_dvd_common.c	(original)
> > > > +++ trunk/stream/stream_dvd_common.c	Sat May 31 14:52:55 2008
> > > > @@ -1,5 +1,9 @@
> > > >  #include <inttypes.h>
> > > > +#ifdef USE_DVDREAD_INTERNAL
> > > >  #include <dvdread/ifo_types.h>
> > > > +#else
> > > > +#include <libdvdread/ifo_types.h>
> > > > +#endif
> > > >  #include "stream_dvd_common.h"
> > > 
> > > Hmmm, I think this will break with external libdvdread, which has its
> > > include files in a dvdread subdirectory.
> > 
> > Not so. Nico has made the necessary changes in SVN already.
> 
> Let me rephrase then: What about the external libdvdread that originated
> with the Ogle project?

I thought you were getting at that.

> Is it unsupported now?  Then I must have missed that change...

Frankly, I don't know what to do with old versions. I guess we should
detect them and either don't use them or keep some compatibility code
for a while.

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | Livna http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan