[MPlayer-cvslog] r26795 - in trunk: DOCS/man/en/mplayer.1 DOCS/man/fr/mplayer.1 Makefile configure help/help_mp-en.h input/appleir.c input/ar.h input/input.c

[Aurelien Jacobs]

Benjamin Zores wrote:

> Aurelien Jacobs a écrit :
> > On Sun, 18 May 2008 19:33:36 +0200
> > Benjamin Zores <ben at geexbox.org> wrote:
> > 
> >> Aurelien Jacobs a écrit :
> >>> On Sun, 18 May 2008 18:33:42 +0200
> >>> Benjamin Zores <ben at geexbox.org> wrote:
> >>>
> >>>> Ivan Kalvachev a écrit :
> >>>>> On 5/18/08, Benjamin Zores <ben at geexbox.org> wrote:
> >>>>>> Diego Biurrun a écrit :
> >>>>>>> On Sun, May 18, 2008 at 01:53:00PM +0200, ben wrote:
> >>>>>>>> --- trunk/Makefile	(original)
> >>>>>>>> +++ trunk/Makefile	Sun May 18 13:53:00 2008
> >>>>>>>> @@ -510,6 +510,7 @@ SRCS_MPLAYER = mplayer.c \
> >>>>>>>>
> >>>>>>>>  SRCS_MPLAYER-$(APPLE_REMOTE) += input/ar.c
> >>>>>>>> +SRCS_MPLAYER-$(APPLE_IR)     += input/appleir.c
> >>>>>>> Ahem...
> >>>>>> Can you be a little bit more explicit ?
> >>>>> Code duplication.
> >>>> Yes sure.
> >>>> One file being MacOSX/Cocoa code only and the other one being Linux 
> >>>> only. Except from the name of the device I dunno what's replicated.
> >>> Not between those 2 files, but between lirc and your new file.
> >>> Yes, lirc support this remote fine under linux.
> >>> What do your own, very specific driver brings over lirc ?
> >> It provides support for the appleir.ko kernel driver which seems
> >> to be defualt on all distributions and work (tested), though lirc
> >> doesn't seem to work with this receiver.
> > 
> > A quick google search on "appleir lirc" shows dozen of poeple
> > using lirc with this hardware... So what's the problem with it ?
> 
> Conflicts. LIRC might work but you need to disable AppleIR.
> But AppleIR driver is shipped with most distros and soon to be included 
> (and so loaded) mainline. Can't say so for LIRC ...

Huh ! If MPlayer can use appleir directly, there is no doubt lirc can
also use appleir. Maybe current lirc uses libusb to access the device
directly or something like that, but in that case, that wouldn't be
a problem to add your code using appleir inside lirc (as a new driver)
instead of adding it in MPlayer.
MPlayer is simply not the place to add specific remote drivers.

Aurel