[MPlayer-cvslog] r26795 - in trunk: DOCS/man/en/mplayer.1 DOCS/man/fr/mplayer.1 Makefile configure help/help_mp-en.h input/appleir.c input/ar.h input/input.c

[Michael Niedermayer]

On Sun, May 18, 2008 at 08:14:31PM +0200, Aurelien Jacobs wrote:
> On Sun, 18 May 2008 19:33:36 +0200
> Benjamin Zores <ben at geexbox.org> wrote:
> 
> > Aurelien Jacobs a écrit :
> > > On Sun, 18 May 2008 18:33:42 +0200
> > > Benjamin Zores <ben at geexbox.org> wrote:
> > > 
> > >> Ivan Kalvachev a écrit :
> > >>> On 5/18/08, Benjamin Zores <ben at geexbox.org> wrote:
> > >>>> Diego Biurrun a écrit :
> > >>>>> On Sun, May 18, 2008 at 01:53:00PM +0200, ben wrote:
> > >>>>>> --- trunk/Makefile	(original)
> > >>>>>> +++ trunk/Makefile	Sun May 18 13:53:00 2008
> > >>>>>> @@ -510,6 +510,7 @@ SRCS_MPLAYER = mplayer.c \
> > >>>>>>
> > >>>>>>  SRCS_MPLAYER-$(APPLE_REMOTE) += input/ar.c
> > >>>>>> +SRCS_MPLAYER-$(APPLE_IR)     += input/appleir.c
> > >>>>> Ahem...
> > >>>> Can you be a little bit more explicit ?
> > >>> Code duplication.
> > >> Yes sure.
> > >> One file being MacOSX/Cocoa code only and the other one being Linux 
> > >> only. Except from the name of the device I dunno what's replicated.
> > > 
> > > Not between those 2 files, but between lirc and your new file.
> > > Yes, lirc support this remote fine under linux.
> > > What do your own, very specific driver brings over lirc ?
> > 
> > It provides support for the appleir.ko kernel driver which seems
> > to be defualt on all distributions and work (tested), though lirc
> > doesn't seem to work with this receiver.
> 
> A quick google search on "appleir lirc" shows dozen of poeple
> using lirc with this hardware... So what's the problem with it ?

Besides, if LIRC doesnt work with it fixing LIRC seems the logic solution
adding a driver to every project that uses LIRC is a rather extreem solution.
All just IMHO ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20080518/0546edab/attachment.pgp>