[MPlayer-cvslog] r26787 - in trunk/libvo: mga_common.c vo_cvidix.c vo_dfbmga.c vo_dga.c vo_directfb2.c vo_fbdev.c vo_ggi.c vo_gl.c vo_gl2.c vo_macosx.m vo_quartz.c vo_svga.c vo_tga.c vo_vesa.c vo_winvidix.c vo_x11.c vo_xover.c vo_xv.c vo_xvidix.c

[Reimar Döffinger]

On Fri, May 16, 2008 at 09:55:58PM +0300, Ivan Kalvachev wrote:
> On Fri, May 16, 2008 at 11:33 AM, diego <subversion at mplayerhq.hu> wrote:
> > Author: diego
> > Date: Fri May 16 10:33:27 2008
> > New Revision: 26787
> >
> > Log:
> > cosmetics: Remove useless parentheses from from return statements.
> 
> Diego, why are you committing controversial cosmetic changes in code
> you don't maintain.
> I strongly request reversal of these commits, they make the code look uglier.

Ugly or not, at least it is consistent. There were about 4 in 50 returns
using the (), with the apparent reason being that someone else having committed
them (I did not actually check that).
That said, I think the
> return (int_pause = 1);
to
> return int_pause = 1;
did not exactly improve things, though I am at a loss what the return
value is supposed to mean -- obviously neither did the author of
vo_dxr3.
How about replacing it with the assignment in a extra line and a return VO_TRUE?

Greetings,
Reimar Döffinger