[MPlayer-cvslog] r26787 - in trunk/libvo: mga_common.c vo_cvidix.c vo_dfbmga.c vo_dga.c vo_directfb2.c vo_fbdev.c vo_ggi.c vo_gl.c vo_gl2.c vo_macosx.m vo_quartz.c vo_svga.c vo_tga.c vo_vesa.c vo_winvidix.c vo_x11.c vo_xover.c vo_xv.c vo_xvidix.c

[Ivan Kalvachev]

On Fri, May 16, 2008 at 10:18 PM, Benjamin Zores <ben at geexbox.org> wrote:
> Ivan Kalvachev a écrit :
>> On Fri, May 16, 2008 at 11:33 AM, diego <subversion at mplayerhq.hu> wrote:
>>> Author: diego
>>> Date: Fri May 16 10:33:27 2008
>>> New Revision: 26787
>>>
>>> Log:
>>> cosmetics: Remove useless parentheses from from return statements.
>>
>> Diego, why are you committing controversial cosmetic changes in code
>> you don't maintain.
>
> Lol, controversial.
> Sure the code has changed quite a lot now, these commits look harmful to me.
>
>> I strongly request reversal of these commits, they make the code look uglier.
>
> That's surely true.
> Removing useless symbols from a line, definitely is uglier, no kidding ...
> This whole situation is getting ridiculous.
>
>> I will reverse them in the modules I maintain.
>
> Then I'll try to add as many () I can on the code I maintain.
> Also I may add random /* :fhg#ùùl$ */ at the end of each line of my code.
> I find it pretty but beauty is just a matter of personnality and as long
> as it's the code I maintain I guess that I can do whatever I want after
> all. Anyhow, it's my code, so I can whatever I want there, I do not care
> whatever one can say, and none of MPlayer rules prevent me from doing
> that. On the contrary, if I do so, and someone tries to remove that,
> then I'll oppose to me and, being Maintainer, my words are gold.
>
>> Why don't you do something useful other than breaking patches for no
>> benefit at all.
>
> Why don't you fucking stop bitching about people that try to work,
> grow up, or start working on MPlayer ?
>
> Or maybe you consider that flaming is benefit to the project ?
> No, let me see, I get it !
> Your whole attitude discourage developers working on MPlayer.
> So maybe, with a bit of luck, they'll leave and MPlayer will be yours ?
> That might sound benefic to the project indeed !!
>
> Maybe you don't like Diego (you don't like Uoti either after all, both
> are free electrons ...) but what you are trying to do here is just
> criticizing every single action one of them does. What's the point ?
> Showing the world you're a damn braindead fucking moron ? Guess what,
> you succeed !
>
> Arg, now you hate me even more you than you already did and you'll just
> revert my latest commits to the awesome code you maintain (btw, did you
> know that vo_xvmc.c uses printf() all over the place instead of mp_msg() ?
> I hope you'll strongly object to Diego's changing that with his
> controversial useless commits, I'll second you on that !).
>
> Now please, be my guest, and revert every single attempt to change
> something to code you maintain.

You are very polite. Thank you for your reply.
I don't remember ever offending you, I apologize if I ever did.
Keep up the good work.