[MPlayer-cvslog] r26411 - trunk/libmpdemux/demuxer.c

[The Wanderer]

Diego Biurrun wrote:

> On Sat, May 10, 2008 at 08:28:51AM -0400, The Wanderer wrote:
>> Benjamin Zores wrote:
>> 
>>> So yes, if you want my opinion, Uoti may have broken some rules
>>> (who the hell defined them after all, probably not a whole team)
>> 
>> AFAIR, they were defined by suggestion and consensus over the
>> course of time.
> 
> Not really.  Most of it was written by Arpi with some modifications
> done over the course of time.

Then it's entirely possible that the rules as they are presently defined
(or possibly ill-defined) may be out of date, and it may be appropriate
to update them - ideally with consensus from the entire development
team, preferably at least with the support of a majority, and certainly
with public discussion beforehand.

It is *not* appropriate to simply ignore them, unless the idea is to
throw the rules out wholesale and not put anything else in their place -
that is, to move to a situation of "no rules at all".

(FTLIW, I do seem to remember various rules - from "no mixing of
cosmetic and functional changes" through "don't casually commit to code
maintained by other people" to the rules embodied in the pre-commit
hooks - being discussed on the mailing lists and agreed upon by some
form of consensus, or at least strong majority... they may have existed
beforehand, but that does not mean they were not agreed upon.)

>>> Ironically, I see that some of the people who asked for his
>>> account revocation may indeed follow these rules, as the few
>>> times they actually commit something, they have few chances to
>>> break them (and no I won't give names, even under torture :-)
>> 
>> My only comment on this is more a response to Diego: it's not
>> exactly fair to count Michael's low MPlayer commit numbers in the
>> same way as those of the others, since his primary area of activity
>> is FFmpeg, and commits there are at least as valuable to MPlayer as
>> commits in the MPlayer repository itself...
> 
> I have the highest respect for Michael both as a person and as a
> developer.  However, FFmpeg is not MPlayer.  They are entirely
> different projects, even though some developers are shared.
> Michael's work on FFmpeg is valuable for MPlayer, as is the work of
> all the other developers.  Nonetheless, status cannot be translated
> 1:1 from one project to the other.

I don't entirely disagree, but my point remains. "Cannot be translated
1:1" does not remotely equal "does not carry over at all", as the
numbers as posted would appear to indicate.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.