[MPlayer-cvslog] r26219 - trunk/mpbswap.h

[Reimar Döffinger]

On Wed, Mar 12, 2008 at 11:09:06AM +0100, Diego Biurrun wrote:
> On Wed, Mar 12, 2008 at 09:20:58AM +0100, Reimar Döffinger wrote:
> > Not to mention that others have given reasons why it is a good idea to
> > place config.h at least before all non-system headers (makes it easy to
> > put system specific hacks in config.h - sure we may never accept such
> > hacks in SVN, but is there a single advantage to _not_ preferring a
> > specific placement of config.h include?)
> 
> That sounds more like a (good) reason to put config.h before all other
> #includes, even system #includes.  After all you might want to put
> things like _GNU_SOURCE or _ISOC9X_SOURCE or other system-specific
> definitions in there.

In principle yes, but in the past we had some conflicts between config.h
and system headers. Hopefully we got rid of that, but that's where my
preference for including as many system headers as possible before
config.h comes from.
Also, simple things like _GNU_SOURCE etc. can be handled with CFLAGS
quite well.