[MPlayer-cvslog] r26219 - trunk/mpbswap.h

[Ivan Kalvachev]

On Wed, Mar 12, 2008 at 3:25 AM, Diego Biurrun <diego at biurrun.de> wrote:
>
> On Wed, Mar 12, 2008 at 03:10:24AM +0200, Ivan Kalvachev wrote:
>  > On Wed, Mar 12, 2008 at 1:40 AM, Diego Biurrun <diego at biurrun.de> wrote:
>  > > On Tue, Mar 11, 2008 at 11:42:48AM +0100, Reimar Döffinger wrote:
>  > >  > On Mon, Mar 10, 2008 at 09:20:08PM +0100, diego wrote:
>  > >  > >
>  > >  > > Log:
>  > >  > > Add missing header #include.
>  > >  > >
>  > >  > > --- trunk/mpbswap.h (original)
>  > >  > > +++ trunk/mpbswap.h Mon Mar 10 21:20:08 2008
>  > >  > > @@ -3,6 +3,8 @@
>  > >  > >
>  > >  > >  #include <sys/types.h>
>  > >  > >  #include "libavutil/bswap.h"
>  > >  > > +#include "config.h"
>  > >  >
>  > >  > Uh, libavutil/bswap.h almost certainly requires config.h, this seems
>  > >  > like a stupid place to put it?
>  > >
>  > >  The whole point is to get rid of magic header order requirements...
>  >
>  > And why is that bad?
>  > You never explained your reasons.
>
>  I gave up arguing with you a long time ago.

So you don't have any reason to do it. You do it just because you can.
I'm quite sure other developers may be interested in your answer.