[MPlayer-cvslog] r26219 - trunk/mpbswap.h

[Uoti Urpala]

On Tue, 2008-03-11 at 19:30 +0100, Aurelien Jacobs wrote:
> > >  > >  > +++ trunk/mpbswap.h   Mon Mar 10 21:20:08 2008
> > >  > >  > @@ -3,6 +3,8 @@
> > >  > >  >
> > >  > >  >  #include <sys/types.h>
> > >  > >  >  #include "libavutil/bswap.h"
> > >  > >  > +#include "config.h"


> Uh, libavutil/bswap.h almost certainly doesn't require anything as
> it is supposed to be self-contained.

> BTW: The real bug here is to include libavutil/bswap.h which is *not*
> part of ffmpeg public API. But that's another story. And it seems
> everyone agree it's OK for MPlayer to deal with ffmpeg internals.

In this case it's not so clear whether it works with config.h after
bswap.h precisely because this is an "internal" FFmpeg header. The
libavutil headers have "#ifdef HAVE_AV_CONFIG_H" before including stuff
like common.h, and that is not defined when compiling under MPlayer. So
I think that in this case config.h should be included first (or some
other hack to deal with FFmpeg-specific defines would be needed).