[MPlayer-cvslog] r26219 - trunk/mpbswap.h

[Reimar Döffinger]

On Tue, Mar 11, 2008 at 01:20:31PM +0200, Ivan Kalvachev wrote:
> On Tue, Mar 11, 2008 at 12:42 PM, Reimar Döffinger
> <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > On Mon, Mar 10, 2008 at 09:20:08PM +0100, diego wrote:
> >  > Author: diego
> >  > Date: Mon Mar 10 21:20:08 2008
> >  > New Revision: 26219
> >  >
> >  > Log:
> >  > Add missing header #include.
> >  >
> >  >
> >  > Modified:
> >  >    trunk/mpbswap.h
> >  >
> >  > Modified: trunk/mpbswap.h
> >  > ==============================================================================
> >  > --- trunk/mpbswap.h   (original)
> >  > +++ trunk/mpbswap.h   Mon Mar 10 21:20:08 2008
> >  > @@ -3,6 +3,8 @@
> >  >
> >  >  #include <sys/types.h>
> >  >  #include "libavutil/bswap.h"
> >  > +#include "config.h"
> >  > +
> >
> >  Uh, libavutil/bswap.h almost certainly requires config.h, this seems
> >  like a stupid place to put it?
> 
> I think I should save you some time and give you the previous answer
> we got from diego about same kind of bug:
> 
> On Sat, Mar 8, 2008 at 4:36 PM, Diego Biurrun <diego at biurrun.de> wrote:
> >  Nonsense.
> >  Diego

I don't claim it to be a bug, I just say it does not make much sense to
me. Also previously the policy I think was if config.h is included it
should be included directly after the system headers.