[MPlayer-cvslog] r26204 - trunk/libvo/vo_svga.c

[Ivan Kalvachev]

On Sun, Mar 9, 2008 at 5:00 PM, Reimar Döffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> On Sun, Mar 09, 2008 at 09:23:04AM -0400, The Wanderer wrote:
>  > Ivan Kalvachev wrote:
>  > > On Sun, Mar 9, 2008 at 2:13 PM, Diego Biurrun <diego at biurrun.de>
>  > > wrote:
>  > >> On Sun, Mar 09, 2008 at 11:34:05AM +0100, iive wrote:
>  >
>  > >>>  static int preinit(const char *arg)
>  > >>>  {
>  > >>> -int i;
>  > >>> +int i,rez;
>  > >>
>  > >> rez is a bad variable name IMO, my first intuition was resolution,
>  > >> not result.
>  > >
>  > > I accept coding advices only from people who can code.
>  >
>  > There's no need to be rude.
>  >
>  > I likewise, upon seeing the abbreviation "rez", think of either
>  > "resolution" or "resurrection". "result" is not even on the list of
>  > candidates unless something about the context suggests it, because the
>  > pronunciation of the vowel is different. I suspect that I am closer to
>  > the norm than the exception in this.
>
>  Hm. I always use "res", it is an obvious and often used abbreviation of
>  "result". Resurrection hardly ever makes sense in a programming context
>  and resolution almost always requires x and y parts, or you just use dpi
>  or so.
>  I do find the use of "z" in completely nonsensical ways extremely
>  annoying, maybe even mostly because it is a typical thing of and in my
>  brain associated with "warez", skript-kiddies and other idiots (sorry
>  iive, just saying my impressions, not directed at you :-) ).

This is extremely polite way to say it.

Anyway, I'm considering removing the offensive variable and just
reusing the existing integer. I'm sure this would be much more
readable [/sarcasm]

BTW I always associate "res" with "resolution". I find is as casual as
using "init" for "initialization".

If it would put your mind at ease you can read "rez" as abbreviation
of "Return Error or Zero". Do you prefer "reoz" or "rze" ?

And don't you all have something better to do than participate in this
bikeshed. I would be happy if somebody test it, as I can't use svgalib
at the moment. I wonder how ironic it would be if there is bug and you
all argue about the name of the variable...

Thank you for the constructive ideas.