[MPlayer-cvslog] r26204 - trunk/libvo/vo_svga.c

[The Wanderer]

Ivan Kalvachev wrote:

> On Sun, Mar 9, 2008 at 2:13 PM, Diego Biurrun <diego at biurrun.de>
> wrote:
>> 
>> On Sun, Mar 09, 2008 at 11:34:05AM +0100, iive wrote:

>>>  static int preinit(const char *arg)
>>>  {
>>> -int i;
>>> +int i,rez;
>>
>> rez is a bad variable name IMO, my first intuition was resolution,
>> not result.
> 
> I accept coding advices only from people who can code.

There's no need to be rude.

I likewise, upon seeing the abbreviation "rez", think of either
"resolution" or "resurrection". "result" is not even on the list of
candidates unless something about the context suggests it, because the
pronunciation of the vowel is different. I suspect that I am closer to
the norm than the exception in this.

> Next time you probably would tell me to use name "iteration" instead
> of "i".

This would be a more fair comparison if he had suggested that you call
it "resolution" instead of "rez", but that's not what he did; he just
said that the current name is unintuitive.

-- 
    The Wanderer

    My usual .sig is on vacation while I adjust to my new computer