[MPlayer-cvslog] r26194 - in trunk/libvo: gl_common.h vesa_lvo.h video_out_internal.h videodev_mjpeg.h vosub_vidix.h w32_common.h

[Ivan Kalvachev]

On Fri, Mar 7, 2008 at 10:25 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Fri, Mar 07, 2008 at 09:19:18PM +0100, Reimar Döffinger wrote:
>  > On Fri, Mar 07, 2008 at 09:07:15PM +0100, diego wrote:
>  > >
>
> > > Log:
>  > > Add missing header #includes to fix 'make checkheaders'.
>  > >
>  > > Modified:
>  > >    trunk/libvo/gl_common.h
>  > >    trunk/libvo/vesa_lvo.h
>  > >    trunk/libvo/video_out_internal.h
>  > >    trunk/libvo/videodev_mjpeg.h
>  > >    trunk/libvo/vosub_vidix.h
>  > >    trunk/libvo/w32_common.h
>  > >
>
> > > --- trunk/libvo/gl_common.h (original)
>  > > +++ trunk/libvo/gl_common.h Fri Mar  7 21:07:15 2008
>  > > @@ -1,6 +1,8 @@
>  > >  #ifndef MPLAYER_GL_COMMON_H
>  > >  #define MPLAYER_GL_COMMON_H
>  > >
>  > > +#include <stdio.h>
>  > > +
>  > >  #include "mp_msg.h"
>  > >  #include "config.h"
>  >
>  > That is quite idiotic, if you want the headers to really work reliably
>  > without extra includes inttypes.h or at least stdint.h is necessary.
>
>  Yes, fixed.
>
>
>  > Hm, mp_msg.h before config.h is a bit weird here...
>
>  It's not important, mp_msg.h is self-contained now :)

Perfect example of sloppy coding.
Expect this to become norm, coz't works.