[MPlayer-cvslog] r27106 - trunk/playtree.c

[Aurelien Jacobs]

ben wrote:

> Author: ben
> Date: Fri Jun 20 21:51:43 2008
> New Revision: 27106
> 
> Log:
> 
> Only "pop" subtree params if they had previously been "pushed",
> and afterwards reset the "pushed" value to 0 again.
> Similarly only set the PLAY_TREE_RND_PLAYED flag
> if the entry had been pushed before.

This patch patch was already submitted and rejected long time ago:
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2003-August/020356.html

Somewhat later, it was revived, with the same conclusion (unacceptable):
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-September/053873.html

What makes you so confident that this patch is now OK (to the point that
you don't even dare to discuss it before commit) ?

Aurel