[MPlayer-cvslog] r27081 - trunk/libmpdemux/demuxer.c

[Benjamin Zores]

Ivan Kalvachev a écrit :
> On 6/16/08, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Mon, Jun 16, 2008 at 12:31:05PM +0200, diego wrote:
>>> Author: diego
>>> Date: Mon Jun 16 12:31:05 2008
>>> New Revision: 27081
>>>
>>> Log:
>>> cosmetics: Consistently format all if, for, while constructs.
>> Iam happy to see someone try to properly cleanup mplayers code, assuming
>> the respective maintainers agreed to it ...
> 
> Are you kidding.
> 
> This is another of Diego tactics 
> "Don't ask, just commit. If somebody objects - ignore him".
> 
> Luca asked if it would be acceptable to unify the coding style of whole
> MPlayer in 24 hours and to first commit pending patches that would be broken by that.
> 
> Diego's answer is to start refactoring demuxer.c in his liking without asking

It's hard for me to say so but I agree with you on that point.

> Not to say that so far Diego have done 12 fully cosmetics commits over single .c file. There are above 1900 .[ch] files, would we need 22800 commits to clean them up?.
> 
> I highly doubt this would be over in 24 hours.

Wasting human time on what can be done by machine is imho a bad idea.

The only solution to me for that is:
- developers agree on a coding style (will take 6 months)
- it has to be reformated through "indent 
_the_necessary_options_for_this_style"
- optionally add a "make indent" rule that call it on all .[hc] files
- best would be afterwards to have an svn handler that automatically 
reindent patches if badly indented.

Ben