[MPlayer-cvslog] r27081 - trunk/libmpdemux/demuxer.c

[Michael Niedermayer]

On Mon, Jun 16, 2008 at 07:34:52PM +0200, Diego Biurrun wrote:
> On Mon, Jun 16, 2008 at 01:24:32PM +0200, Michael Niedermayer wrote:
> > On Mon, Jun 16, 2008 at 12:31:05PM +0200, diego wrote:
> > > 
> > > Log:
> > > cosmetics: Consistently format all if, for, while constructs.
> > 
> > Iam happy to see someone try to properly cleanup mplayers code, assuming
> > the respective maintainers agreed to it ...
> 
> This is Uoti's infamous commit split into a trillion tiny pieces.
> Dominik reminded me that I promised to do this.  Here's hoping that it
> will make even the last nitpicker happy...

See the wanderers explanation of "the problem". Iam not so much nitpicking
about the latest mess, iam complaining about uotis clear statement that
he will not follow "the rules".

Besides its not only about spliting the changes but also having it go
through proper review and approval. It may very well be
that reimar reviewed them and approved them or that he doesnt care, i simply
do not know it.


> 
> > Some comments below though.
> 
> Most don't apply because you commented on an interim version.

if()
else

vs.

if(){
}else

applies to 24 cases in current demuxer.c
There was no agreement on doing these either way, but neither was there
an agreement to change them to the {} less form.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20080616/f6238097/attachment.pgp>