[MPlayer-cvslog] r27081 - trunk/libmpdemux/demuxer.c

[Diego Biurrun]

On Mon, Jun 16, 2008 at 06:29:00PM +0300, Ivan Kalvachev wrote:
> On 6/16/08, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Mon, Jun 16, 2008 at 12:31:05PM +0200, diego wrote:
> >> 
> >> Log:
> >> cosmetics: Consistently format all if, for, while constructs.
> >
> > Iam happy to see someone try to properly cleanup mplayers code, assuming
> > the respective maintainers agreed to it ...
> 
> Are you kidding.
> 
> This is another of Diego tactics 
> "Don't ask, just commit. If somebody objects - ignore him".
> 
> Luca asked if it would be acceptable to unify the coding style of whole
> MPlayer in 24 hours and to first commit pending patches that would be broken by that.
> 
> Diego's answer is to start refactoring demuxer.c in his liking without asking
> for any style guidelines. I guess had checked that there are no pending patches for demuxer.c  
> (The mail about style in -dev is send by Luca after Diego started committing).

This is complete and utter nonsense.  I guess after having refrained
from trolling for over a week, it was high time that you started
again ...

> Not to say that so far Diego have done 12 fully cosmetics commits over
> single .c file.

So you agree that the next time it should be done in one big commit?

> There are above 1900 .[ch] files, would we need 22800
> commits to clean them up?.

You are counting external libraries.  This way, you can only arrive at
nonsensical figures.

> I highly doubt this would be over in 24 hours.

Diego

P.S.: You are still unable to use a proper mail client.