[MPlayer-cvslog] r26411 - trunk/libmpdemux/demuxer.c

[Diego Biurrun]

On Wed, Jun 04, 2008 at 09:29:19PM +0200, Michael Niedermayer wrote:
> On Wed, Jun 04, 2008 at 05:34:13PM +0200, Luca Barbato wrote:
> > Reimar Döffinger wrote:
> > > On Sat, Apr 12, 2008 at 05:51:08PM +0200, uau wrote:
> > >>
> > >> Log:
> > >> Reindent demuxer.c
> > > 
> > > This is not only a reindentation,
> > 
> > It is, at least if you consider reindent as "do what indent does"
> 
> ----------------------------------------
> These remove comments, remove outcommented code, ...
> this definitly is not what indent does and its just what i quickly spotted

We've been over this before.  The commit message was bad, it has been
fixed.  You can hardly accuse Uoti of writing bad commit messages in
general.

> And thats why such commits are so bad and why we all complain, they are a
> nightmare to review, you missed the things above, others missed them too.

I posted a diff without whitespace changes to this thread.  It was not
at all hard to review.  Move on, nothing to see here...

> Besides demuxer.c is not maintained by uoti ...

Other files were reindented without a big outcry before.

Diego