[MPlayer-cvslog] r27240 - trunk/configure

[Michael Niedermayer]

On Tue, Jul 15, 2008 at 10:39:49AM +0200, Diego Biurrun wrote:
> On Tue, Jul 15, 2008 at 01:48:56AM +0200, Michael Niedermayer wrote:
> > On Mon, Jul 14, 2008 at 11:44:57PM +0200, Diego Biurrun wrote:
> > > On Mon, Jul 14, 2008 at 06:54:50PM +0200, Reimar Döffinger wrote:
> > > > On Mon, Jul 14, 2008 at 10:33:16AM +0200, Diego Biurrun wrote:
> > > > > On Sun, Jul 13, 2008 at 12:54:37PM +0200, Reimar Döffinger wrote:
> > > > > > On Sun, Jul 13, 2008 at 12:49:16PM +0200, Diego Biurrun wrote:
> > > > > > > > Could you please post a few of the warnings you where trying to fix. There
> > > > > > > > may be a more correct and clean way to get rid of them.
> > > > > > > 
> > > > > > > Warnings like the following, there was a handful of them:
> > > > > > > 
> > > > > > > libmpcodecs/ad_libvorbis.c: In function 'read_vorbis_comment':
> > > > > > > libmpcodecs/ad_libvorbis.c:48: warning: implicit declaration of function 'vsscanf'
> > > > > > 
> > > > > > Well, at least my man page suggests these solutions to that:
> > > > > > "_XOPEN_SOURCE >= 600 || _ISOC99_SOURCE; or cc -std=c99"
> > > > > > at least strictly speaking, -std=gnu99 is not among the recommended
> > > > > > solutions. In addition, -D_ISOC99_SOURCE would work in all compilers,
> > > > > > not just gcc (though ICC probably supports it anyway and no other
> > > > > > compiler is supported. Still...).
> > > > > 
> > > > > Which manual page is that?
> > > > 
> > > > man vsprintf
> > > > Linux Programmer’s Manual
> > > > This page is part of release 2.80 of the Linux man-pages project.
> > > > It does not exactly suggest these solutions, but more precisely says:
> > > > "   Feature Test Macro Requirements for glibc (see feature_test_macros(7)):
> > > > 
> > > >        snprintf(), vsnprintf(): _BSD_SOURCE || _XOPEN_SOURCE >= 500 || _ISOC99_SOURCE; or cc -std=c99
> > > > "
> > > 
> > > I looked at the manual page of vsscanf.  There was no mention of this in
> > > there.  In fact, there is no such thing in my vsprintf man page
> > > either...
> > 
> > It is in mine here as well
> > " This  page  is  part  of  release  3.00 of the Linux man-pages project.  A description of the project, and information about reporting bugs, can be found at http://www.kernel.org/doc/man-pages/."
> > and
> > "This  page  is  part  of  release  2.79 of the Linux man-pages project.  A description of the project, and information about reporting bugs, can be found at http://www.kernel.org/doc/man-pages/."
> > 
> > I dont have any computer here with an older version
> > 
> > The online version at
> > http://www.kernel.org/doc/man-pages/online/pages/man3/vsscanf.3.html
> > which is 3.03 also contains the *_SOURCE defines
> > 
> > Which ancient version do you have?
> 

> I have 2.39 on my Debian stable box and 3.02 on my unstable box.  The
> latter does indeed mention more things.  However, I mostly work on the
> former...

Ahh debian stable ...
no that predates C99

Let me quote it for you:
LINUX MANPAGE                                                                1995-11-01

1995 < 1999

They obviously cannot mention the proper way to use these functions because
they where not standard back then

also, it does NOT list vsscanf() in the conforming section as conforming to
anything. (not to surprising ...)

So i really think you should maybe not base your work on man pages that
predate the standards you try to use.


PS: thanks to the history museum for proving the debian stable box ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20080715/59e15a51/attachment.pgp>