[MPlayer-cvslog] r27195 - trunk/stream/stream_dvd.c

[Aurelien Jacobs]

On Sun, 06 Jul 2008 15:40:57 +0200
Nico Sabbi <nicola.sabbi at poste.it> wrote:

> Il giorno dom, 06/07/2008 alle 14.40 +0200, Aurelien Jacobs ha scritto:
> > On Sun, 06 Jul 2008 12:06:56 +0200
> > Nico Sabbi <nicola.sabbi at poste.it> wrote:
> > > what about this? simpler and nicer to read IMO
> > 
> > I haven't read the whole code, so I can't really tell,
> > but wouldn't this be enough ?
> > 
> > -      dvd_device_current = strdup(DEFAULT_DVD_DEVICE);
> > +      dvd_device_current = DEFAULT_DVD_DEVICE;
> > 
> > Aurel
> 
> I used strdup() in order to unify the free(dvd_device_current) in
> dvd_close()

I've understood this. I was just suggesting that it may be possible
to never use strdup so that dvd_device_current never need to be free().
But once again, I haven't checked the code, so I may be plain wrong.

Aurel