[MPlayer-cvslog] r25897 - in trunk:?libass/mputils.h?libmpcodecs/ae.h libmpcodecs/ae_faac.h?libmpcodecs/ae_toolame.h?libmpcodecs/ae_twolam e.h?libmpcodecs/mpc_info.h?libmpcodecs/native/mmx.h?libmpcodecs/vqf. h?libmpdemux/demux_xmms_plugin.h libvo/f

[Reimar Döffinger]

Hello,
On Tue, Jan 29, 2008 at 09:16:42AM +0300, Evgeniy Stepanov wrote:
> No, this is not about separate projects. I think that MPUTILS_H is too short 
> and we are just lucky there is no other mputils.h anywhere in mplayer. I'd 
> suggest using directory names in all inclusion guards: LIBASS_MPUTILS_H, 
> LIBMPCODECS_VF_H, so on. Maybe even a full path: 
> LIBMPCODECS_NATIVE_MMX_H. Bandwidth is cheap these days :)

Well, in principle I guess yes, but firstly it has mostly been like this
for ages without causing problems and secondly with stuff that is only
used in MPlayer we have full control over it and can quickly hack around
problems if that is necessary.