[MPlayer-cvslog] r25894 - trunk/libmpcodecs/native/alaw.h
michaelni at gmx.at
Mon Jan 28 00:36:44 CET 2008
On Sun, Jan 27, 2008 at 10:23:44PM +0100, Roberto Togni wrote:
> On Sun, 27 Jan 2008 21:57:02 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
> > On Sun, Jan 27, 2008 at 08:32:56PM +0100, Roberto Togni wrote:
> > > On Sun, 27 Jan 2008 19:49:25 +0100 (CET)
> > > diego <subversion at mplayerhq.hu> wrote:
> > >
> > > > Log:
> > > > Replace with the output of the updated alaw-gen generator program.
> > > > This adds multiple inclusion guards and reformats the tables.
> > >
> > > WTF?
> > >
> > > There is no need to reformat the file to add multiple inclusion
> > > protection.
> > > And the table was already aligned.
> > >
> > > Please revert.
> > Umm, why? Because the commit mixes multiple changes? Look at the
> > changes I did to alaw-gen.c beforehand. This commit replaces the old
> > header file with the output of the new alaw-gen program...
> Because you don't need to replace the file to add 3 lines, even if the
> file was originally generated by a program; now that the file is in svn
> it should be treated like other non-generated files (eg. the const was
> added by hand). Replacing the file make sense only if you are changing
> the content of all the tables for non-cosmetic reasons (eg. if they are
> broken, or you need to change the values to float, ...)
> Because of the huge useless cosmetic changes, in violation of our
> policy (you're not allowed to change formatting of files with no good
> Because not reverting this gives the false impression that this kind of
> commits are ok
> Because not reverting this would would be yet another proof that the
> "do it, nobody will bother to revert it" attitude is the winning one
i fully agree
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the MPlayer-cvslog