[MPlayer-cvslog] r25859 - trunk/mplayer.c

[Reimar Döffinger]

On Sat, Jan 26, 2008 at 09:06:03PM +0100, Benjamin Zores wrote:
> Reimar Döffinger a écrit :
> > Hello,
> > On Sat, Jan 26, 2008 at 05:18:58PM +0100, ben wrote:
> >> Modified: trunk/mplayer.c
> >> ==============================================================================
> >> --- trunk/mplayer.c	(original)
> >> +++ trunk/mplayer.c	Sat Jan 26 17:18:58 2008
> >> @@ -3769,6 +3769,14 @@ if(auto_quality>0){
> >>     mp_dvdnav_get_highlight (mpctx->stream, &hl);
> >>     osd_set_nav_box (hl.sx, hl.sy, hl.ex, hl.ey);
> >>     vo_osd_changed (OSDTYPE_DVDNAV);
> >> +
> >> +   if (mp_dvdnav_stream_has_changed(mpctx->stream)) {
> >> +     double ar = -1.0;
> >> +     if (stream_control (mpctx->demuxer->stream,
> >> +                         STREAM_CTRL_GET_ASPECT_RATIO, &ar)
> >> +         != STREAM_UNSUPPORTED)
> >> +       mpctx->sh_video->stream_aspect = ar;
> >> +   }
> > 
> > Hmm.. That "!= STREAM_UNSUPPORTED" condition does not make sense to me.
> > Does it really make sense that upon mp_dvdnav_stream_has_changed we
> > leave the aspect unchanged if STREAM_CTRL_GET_ASPECT_RATIO is not
> > supported but set it to -1 if we get an error?
> > Or actually, is it sensible to assume that ar even has valid content and
> > is not just undefined when STREAM_CTRL_GET_ASPECT_RATIO fails with e.g.
> > STREAM_ERROR?
> 
> Hum, stream_aspect is not updated (at least not to -1) if 
> stream_control() fails.

???? If it returns STREAM_ERROR, stream_aspect will be set to whatever
is in ar!