[MPlayer-cvslog] r25843 - trunk/command.c

[Benjamin Zores]

Reimar Döffinger a écrit :
> Hello,
> On Thu, Jan 24, 2008 at 07:02:48PM +0100, Benjamin Zores wrote:
>> Reimar Döffinger a écrit :
>>> On Thu, Jan 24, 2008 at 09:55:11AM +0100, Benjamin Zores wrote:
>>>>> I think I missed why the ass_enabled check is supposed to make sense.
>>>>> And I certainly don't see why you changed your original patch in a way
>>>>> that doubles the number of #ifdefs!
>>>> Would it make sense to updated both text_font and ass_font scaler at
>>>> the same time ?
>>>> I still don't see how both can be used at the same time.
>>>> But if they can, I have no problem updating this to handle both (but
>>>> not until tonight).
>>> Well, the sense I can see in it that it about halves the amount of code.
>>> So you are asking the completely wrong question, the right one is: is
>>> there a reason to have an additional check in the code?
>>> If not, please get rid of the clutter.
>> Ok, I did more tests and I'll remain and my current patch.
>> Changing both OSD font and ASS subtitle is really bad when using libmenu.
>> Both are getting updated and it's absolutely not the expected behavior.
> 
> So it is supposed to be the expected behaviour that when using -ass
> mp_property_sub_scale does not change the libmenu stuff but it does when
> not using it?
> I can't think of a better way to describe this that "idiotic"!
> Next time please think of a way to do things in a way that make sense
> _before_ committing, the user interface is not supposed to work like
> some kind of random number generator!

Hang on !
This was already the case before my patch !
That's what happen when the same font is used for OSD and Subs rendering.

Ben