[MPlayer-cvslog] r25777 - in trunk/libswscale: rgb2rgb_template.c swscale-example.c swscale.c swscale_altivec_template.c swscale_template.c yuv2rgb_altivec.c

[Guillaume Poirier]

Hello,

Benoit Fouet wrote:
> Diego Biurrun wrote:
>> On Thu, Jan 17, 2008 at 09:57:15AM +0100, benoit wrote:
>>   
>>> Log:
>>> Remove non cosmetic spaces inside parentheses.
>>>
>>> --- trunk/libswscale/swscale.c	(original)
>>> +++ trunk/libswscale/swscale.c	Thu Jan 17 09:57:15 2008
>>> @@ -1597,9 +1597,9 @@ static int PlanarToNV12Wrapper(SwsContex
>>>      dst = dstParam[1] + dstStride[1]*srcSliceY/2;
>>>      if (c->dstFormat == PIX_FMT_NV12)
>>> -        interleaveBytes( src[1],src[2],dst,c->srcW/2,srcSliceH/2,srcStride[1],srcStride[2],dstStride[0] );
>>> +        interleaveBytes(src[1],src[2],dst,c->srcW/2,srcSliceH/2,srcStride[1],srcStride[2],dstStride[0]);
>>>     
>> Why not add spaces between function arguments while you're at it?
>>
>>   
> 
> I'll try that too, thanks...
> I guess that removing parentheses is ok only if it doesn't create new
> warnings, or ?

That's what I think too indeed. But please test with the very latest
version of GCC, if possible GCC 4.3.0 since the latest version have a
tendency to put a shitload of warnings about parentheses.

Guillaume