[MPlayer-cvslog] r25556 - trunk/libmenu/menu_filesel.c

[Ulion]

2008/1/16, Rich Felker <dalias at aerifal.cx>:
> On Tue, Jan 15, 2008 at 11:41:40AM +0800, Zuxy Meng wrote:
> > "Rich Felker" <dalias at aerifal.cx> 写入消息新闻:20080115003128.GX32433 at brightrain.aerifal.cx...
> > > On Mon, Jan 14, 2008 at 06:11:41PM +0800, Zuxy Meng wrote:
> > >> >> Anyway, has this patch been reviewed ever?
> > >> >
> > >> > OK, that part of code was denied now. Then you may implement it in a
> > >> > better way if you'd like to. By now I have little time work on it and
> > >> > also have no idea of a better implementation.
> > >>
> > >> I don't know what's the best to replace realpath(). Maybe ppl on the
> > >> devel mailing list will have a better idea.
> > >
> > > Maybe you could start by explaining why you want the functionality of
> > > realpath. It seems very undesirable to me but perhaps I'm missing
> > > something.
> >
> > See the CVS log. Ulion tried to default the directory to where the
> > current played file resides, by expanding the full path of the
> > current file and stripping the filename.
>
> Just strip the filename. There is no need to canonicalize the rest of
> the pathname and in fact this is even harmful to users who are trying
> to make good use of symbolic links.
>
> Also, please fix your mailer. It's not wrapping lines so I see long
> long lines that require scrolling right or re-wrapping to read.

The raw filename may look like '../../../mediafile.ext', after remove
the basename, the left part make no sense, unless we figure out the
fullpach and remove the '../' like stuff. Any idea?


-- 
Ulion