[MPlayer-cvslog] r25647 - in trunk: gui/wm/wsxdnd.c vidix/sis_regs.h

[Diego Biurrun]

On Tue, Jan 08, 2008 at 08:47:12AM +0900, Andrew Calkin wrote:
> 2008/1/8, diego <subversion at mplayerhq.hu>:
> >
> > Log:
> > Fix illegal identifier, names starting with _ and uppercase are reserved.
> >
> > --- trunk/vidix/sis_regs.h      (original)
> > +++ trunk/vidix/sis_regs.h      Tue Jan  8 00:43:10 2008
> > @@ -383,16 +383,16 @@
> > -#define _VINWID                                  704
> > -#define _VINHGT                         _VINHGT_NTSC
> > -#define _VINHGT_NTSC                             240
> > -#define _VINHGT_PAL                              290
> > -#define _VIN_WINDOW                  (704 * 291 * 2)
> > -#define _VBI_WINDOW                   (704 * 64 * 2)
> > +#define VINWID                                   704
> > +#define VINHGT                           VINHGT_NTSC
> > +#define VINHGT_NTSC                              240
> > +#define VINHGT_PAL                               290
> > +#define VIN_WINDOW                   (704 * 291 * 2)
> > +#define VBI_WINDOW                    (704 * 64 * 2)
> >
> > -#define _VIN_FIELD_EVEN                            1
> > -#define _VIN_FIELD_ODD                             2
> > -#define _VIN_FIELD_BOTH                            4
> > +#define VIN_FIELD_EVEN                             1
> > +#define VIN_FIELD_ODD                              2
> > +#define VIN_FIELD_BOTH                             4
> >
> >
> >  /* i2c registers (TW; not on 300/310/325 series) */
> 
> This change looks suspicious. You changed defines, but no place where
> those defines are used?

Well, they are partially used in there, but in any case grep did not
find them anywhere else...

Diego