[MPlayer-cvslog] r25641 - in trunk/libass: ass.h ass_library.c

[Evgeniy Stepanov]

On Tuesday 08 January 2008 02:38:33 Uoti Urpala wrote:
> On Mon, 2008-01-07 at 15:02 +0100, eugeni wrote:
> > Copy font data to ass_library instead of referencing demuxer-owned
> > memory.
> >
> > This fixes segfault when fonts are accessed after demuxer has been
> > closed.
>
> This will keep collecting fonts in memory, including multiple identical
> copies of the same font(s) if you play the same file multiple times.
>
> Moving the fonts from per-library-instance to per-renderer might not be
> a good solution as it would likely duplicate them between tracks of the
> same file. Maybe there should be a per-file level between those?
>
> Another possibility could be to allow different fonts to accumulate but
> try to detect and remove multiple instances of the same font.

I'm thinking of clearing all fonts when the file is changed.
May be a good place for that is somewhere around mplayer.c:3653 ?