[MPlayer-cvslog] r25592 - trunk/configure

[Rich Felker]

On Thu, Jan 03, 2008 at 02:44:58AM +0100, uau wrote:
> Author: uau
> Date: Thu Jan  3 02:44:58 2008
> New Revision: 25592
> 
> Log:
> Add HAVE_SOCKLEN_T to config.h for FFmpeg
> 
> Needed to fix compilation after recent FFmpeg changes. It's now always
> set to true without any tests. I don't expect this to cause problems
> as common systems will have the type and the FFmpeg demuxers which
> would use it are not compiled under MPlayer (compilation was broken
> because the type was redefined in a header).

I have a proposal for ugly things like this. Instead of HAVE_FOO for
_standard_ features which should always be expected to be present by
default, the macro should instead be MISSING_FOO. Then the code will
compile correctly even with an empty config.h on sane systems, and
only broken systems may encounter problems.

Rich