[MPlayer-cvslog] r26113 - in trunk: mencoder.c mplayer.c

[Rich Felker]

On Fri, Feb 29, 2008 at 06:18:53AM +0200, Uoti Urpala wrote:
> On Thu, 2008-02-28 at 22:54 -0500, Rich Felker wrote:
> > On Thu, Feb 28, 2008 at 08:41:40PM +0100, reimar wrote:
> > > -    demuxer_seek_chapter(demuxer, dvd_chapter-1, 1, &pts, NULL, NULL);
> > > +    if (demuxer_seek_chapter(demuxer, dvd_chapter-1, 1, &pts, NULL, NULL) >= 0 && pts > -1.0)
> > > +      seek_to_sec = pts;
> > 
> > seek_to_sec does not remotely work for most file types, especially
> > dvds. The old -chapter was byte-exact! Please fix this nasty
> > regression that makes splitting dvds when encoding essentially
> > impossible!
> 
> Did you test that there is a real regression? demuxer_seek_chapter()
> does the actual seek if supported by the stream layer, and this code
> does not set seek_to_sec unconditionally.

Oh, maybe I misunderstood it then..?

Rich