[MPlayer-cvslog] r28151 - trunk/mangle.h

[Reimar Doeffinger]

On Wed, Dec 17, 2008 at 01:11:32AM +0100, Diego Biurrun wrote:
> On Mon, Dec 15, 2008 at 05:38:25PM +0100, Diego Biurrun wrote:
> > On Mon, Dec 15, 2008 at 05:15:35PM +0100, Reimar Döffinger wrote:
> > > On Mon, Dec 15, 2008 at 05:52:21PM +0200, Uoti Urpala wrote:
> > > > On Mon, 2008-12-15 at 14:53 +0100, reimar wrote:
> > > > > Modified: trunk/mangle.h
> > > > 
> > > > > +#define MANGLE(a) EXTERN_PREFIX #a
> > > > 
> > > > EXTERN_PREFIX is defined in config.h but mangle.h does not #include it.
> > > > At least mp3lib has files using mangle.h which do not already include
> > > > config.h and so will fail to compile.
> > > 
> > > Hm, only two files had that issue, so I decided to fix it by including
> > > config.h in those files.
> > 
> > Please do it the other way around, otherwise you will break 'make
> > checkheaders' and also you have to make sure that config.h is #included
> > with every use of mangle.h.
> 
> I don't mind doing this myself as long as it gets done, so I will make
> the change soon.

I wanted to add config.h to mangle.h this morning, but public internet access
is not working here again...
I am against doing it "the other way round" which would leave those two files
the only ones that do not include config.h which I think is bad consistency-wise,
particularly since those are exactly two files that aren't compiled on AMD systems.