[MPlayer-cvslog] r28085 - in trunk: cfg-mencoder.h cfg-mplayer.h gui/app.h gui/cfg.c gui/cfg.h gui/interface.h gui/mplayer/gmplayer.h gui/mplayer/gtk/about.h gui/mplayer/gtk/eq.h gui/mplayer/gtk/fs.c gui/mplayer/gtk/fs.h gui/mplayer/gtk/gtk_common.h gui/mplayer/gtk/gtk_url.h gui/mplayer/gtk/mb.h gui/mplayer/gtk/menu.h gui/mplayer/gtk/opts.h gui/mplayer/gtk/pl.h gui/mplayer/gtk/sb.h gui/mplayer/gui_common.c gui/mplayer/gui_common.h gui/mplayer/mw.c gui/mplayer/pb.c gui/mplayer/play.h gui/mplayer/widgets.h gui/skin/cut.h gui/skin/font.h gui/skin/skin.h gui/win32/dialogs.c gui/win32/gui.c gui/win32/gui.h gui/win32/playlist.h gui/win32/skinload.h gui/win32/wincfg.c gui/wm/ws.h input/input.h libaf/af_format.h libaf/filter.h libaf/window.h libao2/ao_dxr2.c libao2/ao_ivtv.c libao2/ao_v4l2.c libass/ass_mp.c libmpcodecs/ad_acm.c libmpcodecs/ad_twin.c libmpcodecs/dec_audio.h libmpcodecs/dec_video.h libmpcodecs/vd_vfw.c libmpdemux/demux_asf.c libmpdemux/demux_audio.c libmpdemux/demux_avi.c libmpdemux/demux_lavf.c libmpdemux/demux_mpg.c libmpdemux/demux_ogg.c libmpdemux/demux_real.c libmpdemux/demux_realaud.c libmpdemux/demux_ts.c libmpdemux/demux_ty.c libmpdemux/demuxer.c libmpdemux/demuxer.h libmpdemux/muxer_mpeg.c libvo/aspect.h libvo/fastmemcpy.h libvo/osd.h libvo/sub.c libvo/sub.h libvo/video_out.h libvo/vo_directx.c libvo/vo_macosx.m libvo/vo_quartz.c libvo/vo_winvidix.c libvo/vo_xvidix.c libvo/w32_common.h loader/dmo/DMO_AudioDecoder.c loader/elfdll.c loader/ext.h loader/registry.c loader/win32.c loader/win32.h loader/wine/debugtools.h loader/wine/heap.h loader/wine/ldt.h loader/wine/module.h loader/wine/pe_image.h loader/wine/winnt.h loader/wrapper.h mencoder.c mixer.h mp3lib/mp3.h mp3lib/mpg123.h mp3lib/sr1.c mp_msg.c mplayer.c mplayer.h osdep/getch2.c osdep/getch2.h osdep/timer.h parser-mpcmd.c stream/cache2.h stream/cookies.h stream/dvbin.h stream/http.c stream/stream_cdda.c stream/stream_dvb.c vidix/dha.h vidix/pci_db2c.awk vidix/sis_vid.c vidix/sysdep/AsmMacros_alpha.h vidix/sysdep/pci_win32.c vobsub.h

[Uoti Urpala]

On Thu, 2008-12-04 at 15:42 +0100, Reimar Döffinger wrote:
> On Thu, Dec 04, 2008 at 02:38:39PM +0100, Michael Niedermayer wrote:
> > On Thu, Dec 04, 2008 at 12:01:04AM +0100, diego wrote:
> > [...]
> > > Modified: trunk/loader/wrapper.h
> > > ==============================================================================
> > > --- trunk/loader/wrapper.h	(original)
> > > +++ trunk/loader/wrapper.h	Thu Dec  4 00:01:03 2008
> > > @@ -11,10 +11,10 @@ typedef int (*wrapper_func_t)(void *stac
> > >  
> > >  extern wrapper_func_t report_entry, report_ret;
> > >  
> > > -extern void (*wrapper_target)(void);
> > > +void (*wrapper_target)(void);
> > 
> > may i suggest that you test that mplayer before and after the removial of
> > pointless externs is binary identical, in the
> > "md5sum mplayer mencoder" sense 
> 
> Um, if it made a difference it wouldn't compile.

Yes, testing binary identicality is pointless; but it could compile
(without difference) on usual platforms and still not have exactly the
same semantics. By default the linker will allow multiple files to
define a global variable as long as at most one of them has an
initializer. Adding -fno-common to cflags prevents that and triggers a
link time "multiple definition" error. I tested compilation with that
and didn't get any errors.