[MPlayer-cvslog] r26352 - in trunk: Makefile osdep osdep/Makefile

[Diego Biurrun]

On Sun, Apr 13, 2008 at 12:48:18AM +0200, Alban Bedel wrote:
> On Sat, 12 Apr 2008 23:50:23 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Sat, Apr 12, 2008 at 01:07:22PM +0200, Alban Bedel wrote:
> > > On Tue,  8 Apr 2008 20:25:30 +0200 (CEST)
> > > diego <subversion at mplayerhq.hu> wrote:
> > > 
> > > > +SRCS_COMMON-$(HAVE_SYS_MMAN_H)       += osdep/mmap_anon.c
> > > > +SRCS_COMMON-$(MACOSX_FINDER_SUPPORT) +=
> > > > osdep/macosx_finder_args.c +SRCS_COMMON-$(NEED_GETTIMEOFDAY)
> > > > += osdep/gettimeofday.c +SRCS_COMMON-$(NEED_GLOB)             +=
> > > > osdep/glob-win.c +SRCS_COMMON-$(NEED_SETENV)           +=
> > > > osdep/setenv.c +SRCS_COMMON-$(NEED_SHMEM)            +=
> > > > osdep/shmem.c +SRCS_COMMON-$(NEED_STRSEP)           +=
> > > > osdep/strsep.c +SRCS_COMMON-$(NEED_SWAB)             +=
> > > > osdep/swab.c +SRCS_COMMON-$(NEED_VSSCANF)          +=
> > > > osdep/vsscanf.c
> > > 
> > > This is a severe set back for the TOOLS! How are we supposed to link
> > > osdep.a in now? You can't just put everything in SRCS_COMMON, it
> > > should still be grouped by lib to allow using a subset.
> > 
> > Just link against whatever object you need.
> 
> And have the link break even more often than before? I thought we
> wanted to improve the situation. This new scheme is by far a lot worse
> regarding maintainability of the tools.
> 
> Why do you (seems to) refuse hearing anything about splitting the
> source list across a few variables? Do you really think that having to
> duplicate the list of required sources is better? Not mentioning that
> building such source list is far from trivial with all those
> conditionals.

I never said anything to this effect.

Diego