[MPlayer-cvslog] r26352 - in trunk: Makefile osdep osdep/Makefile

Diego Biurrun diego at biurrun.de
Wed Apr 9 17:59:16 CEST 2008


On Wed, Apr 09, 2008 at 07:47:15PM +0400, Michael Kostylev wrote:
> 
> At Wed, 9 Apr 2008 16:14:19 +0200,
> Diego Biurrun wrote:
> 
>  >> Looks like you've lost osdep/mmap-os2.c,
>  > Yes!  Thanks a bundle for pointing this out, fixed.
>  >> OTOH it had been included in r26350 in an unportable manner.
>  > What was unportable about that?
> 
> It should be like this or something better:
> 
> -SRCS_COMMON-$(NEED_MMAP)             += osdep/mmap-os2.c
> +SRCS_COMMON-$(NEED_MMAP)             += osdep/$(MMAP)
> 
> (with corresponding changes in configure, of course) 

Currently we only have this mmap implementation for OS/2.  I don't
expect others to arrive anytime soon, so this is a minor detail.

Diego



More information about the MPlayer-cvslog mailing list