[MPlayer-cvslog] r24309 - in trunk/libswscale: swscale.c swscale_internal.h yuv2rgb.c

[Diego Biurrun]

On Tue, Sep 04, 2007 at 03:58:19PM -0400, Marc Hoffman wrote:
> On 8/31/07, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > On Fri, Aug 31, 2007 at 03:43:45PM -0400, Marc Hoffman wrote:
> > > On 8/31/07, Rich Felker <dalias at aerifal.cx> wrote:
> > > > On Fri, Aug 31, 2007 at 04:57:50PM +0200, mhoffman wrote:
> > > > >
> > > > > Log:
> > > > > renaming ARCH_BFIN to HAVE_BFIN
> > > >
> > > > Is bfin an arch or a feature of another cpu type? This change seems
> > > > suspicious..
> > >
> > > I guess this must have confused me, what is the correct way for me to
> > > solve this configuration issue?
> > >
> > > #ifdef HAVE_MMX2
> > >     flags |= SWS_CPU_CAPS_MMX|SWS_CPU_CAPS_MMX2;
> > > #elif defined (HAVE_3DNOW)
> > >     flags |= SWS_CPU_CAPS_MMX|SWS_CPU_CAPS_3DNOW;
> > > #elif defined (HAVE_MMX)
> > >     flags |= SWS_CPU_CAPS_MMX;
> > > #elif defined (HAVE_ALTIVEC)
> > >     flags |= SWS_CPU_CAPS_ALTIVEC;
> > > #elif defined (HAVE_BFIN)
> > >     flags |= SWS_CPU_CAPS_BFIN;
> > > #endif
> > > #endif /* RUNTIME_CPUDETECT */
> >
> > Hmm... what the heck is this doing in runtime cpu detection?
> > Interestingly BFIN is in _cpuexts_all, but it is never set in
> > _cpuexts...
> > I do not know what patch you use to add bfin support, but I'd think that
> > you should add BFIN to _arch_all and set _arch to BFIN (and remove it
> > from _cpuexts_all/_cpuexts).
> 
> Thanks for the direction I will try it and fix this so that I'm using ARCH_BFIN.

It's been 3 weeks, this issue is still standing.  Setting HAVE_BFIN is
incorrect.  MPlayer's configure needs to be fixed to set ARCH_BFIN
instead, just like FFmpeg's configure.

Diego