[MPlayer-cvslog] r24536 - trunk/vidix/nvidia_vid.c

[Sascha Sommer]

Hi,

On Monday 17 September 2007 16:08, Guillaume LECERF wrote:
> 2007/9/17, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Are you sure the new X-resolution code is any more correct on older
> > cards? I'd expect it to be pure luck that that it works, at least I doubt
> > nVidia would have reserved some bits wildly dispersed for resolutions the
> > card can't even handle anyway...
>
> This patch comes from rivatv code source, which is the base of
> nvidia_vid.c. I found this commit
> http://rivatv.cvs.sourceforge.net/rivatv/rivatv/src/v4l-riva.c?r1=1.8&r2=1.
>9 that was fixing the resolution detection. I tested it on my nv40 card, and
> it fixed the bug (screen_y was wrongly detected without it).
>
> As it's been commited to rivatv cvs, I thought it had been tested by
> their community. That's why I think that enabling this new routine
> only for archs > nv10 could be good.
> Could some people with acces to nvidia cards could test the attached patch
> ?

I checked the noveau sources. The only register that does not seem to get 
written for NV03 and NV04 is NV_VGA_CRTCX_EXTRA (0x41).

I therefore changed your patch to be >= NV_ARCH_10 and applied it.
Tested on NV03 and NV10

Btw. nouveau also seems to have support for YV12 on some of the newer cards.
If someone wants to work on this the attached (untested) patch might be a 
starting point.

Regards

Sascha


-------------- next part --------------
A non-text attachment was scrubbed...
Name: nvidia_vid_yv12.patch
Type: text/x-diff
Size: 3687 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20070917/a7d812bc/attachment.patch>