[MPlayer-cvslog] r24362 - in trunk: mpcommon.c stream/tv.h stream/tvi_vbi.c

Vladimir Voroshilov voroshil at gmail.com
Sat Sep 8 12:04:54 CEST 2007


2007/9/8, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Sep 08, 2007 at 05:06:23AM +0200, voroshil wrote:
> [...]
> > +    case TV_VBI_CONTROL_IS_CHANGED:
> > +        if((GetTimerMS()/250)%2)  //forcing page update every 1/4 sec
> > +            priv->page_changed=3; //mark that header update is enough
>
> I don't think this is such a good way of doing this.
> First, this forces an update every 500, not 250 ms.
> Second, if for some reason TV_VBI_CONTROL_IS_CHANGED is called rarely
> and at the wrong times, this might never trigger at all.
> The later problem could probably be fixed by storing the timestamp of the last
> update and checking the delta.

Fixed in this way.
Thank you.

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719



More information about the MPlayer-cvslog mailing list