[MPlayer-cvslog] r24798 - in trunk: libmpcodecs/ve_vfw.c loader/win32.c loader/wine/objbase.h

[Compn]

On Thu, 18 Oct 2007 11:42:53 +0200, Diego Biurrun wrote:

>On Wed, Oct 17, 2007 at 09:56:03PM -0400, Compn wrote:
>> On Wed, 17 Oct 2007 15:06:40 +0200, Diego Biurrun wrote:
>> 
>> >On Wed, Oct 17, 2007 at 07:14:21AM +0200, compn wrote:
>> >> 
>> >> Log:
>> >> vfw fixes
>> >> patch by Gianluigi Tiesi mplayer___netfarm.it
>> >> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-September/054136.html
>> >
>> >You have merged two separate patches into one.  This is
>> >unacceptable, revert this commit.
>> 
>> [21:41] <Sherpya> Compn: 24798 commit is unsplittable
>
>This makes one wonder why it was submitted as two patches...

uau asked him on irc....

[22:03] <uau> if the commit was "unsplittable" then why was it posted
as two separate patches? (note i don't want it split afterwards, but
the posts seem inconsistent)
[22:04] <Sherpya> splitting them would make the trunk unbuildable
[22:05] <Sherpya> hmm let me see wath I've posted :D
[22:05] <Compn>
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-September/054136.html
[22:06] <Sherpya> yes I shoudn't have splitted

i linked to the two patches because at least reimar reviewed it
and it was very similar to this patch (only one or two line changes).

>
>> >Also, the commit message is bad, ask the patch submitter for a
>> >better one if you cannot come up with one yourself.
>> 
>> done
>
>It can still be improved, see my comment on the log message update..

we've been hashing it out on irc. does this sound better?

Add Coinitialize function to vfw encoder and win32 loader.
Fixes crash when trying to load vp7vfw.dll in vfw2menc.
Patch by Gianluigi Tiesi mplayer___netfarm.it
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-September/054136.html


>> >> --- (empty file)
>> >> +++ trunk/loader/wine/objbase.h	Wed Oct 17 07:14:21 2007
>> >> @@ -0,0 +1,19 @@
>> >> +#ifndef WINE_OBJBASE_H
>> >> +#define WINE_OBJBASE_H
>> >> + [...]
>> >> +#endif
>> >
>> >Please add a comment to the #endif.
>> 
>> will do if its ok not to revert etc
>
>If the patches are in fact one patch - as it seems they are - then do
>not revert and please add the comment.

done

-compn