[MPlayer-cvslog] r25197 - trunk/vobsub.c

[Ulion]

2007/11/29, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Thu, Nov 29, 2007 at 04:35:51AM +0100, ulion wrote:
> > Author: ulion
> > Date: Thu Nov 29 04:35:50 2007
> > New Revision: 25197
> >
> > Log:
> > Even when vobsub is forced, .ifo file is still not necessary,
> > so change the log level from error to warning.
>
> Well, if it was necessary _FATAL IMO would have been the right message
> level. I think without the ifo the colours may be wrong, so ERR was not
> entirely wrong. Though WARN probably is just as good.

Earlier vob may rely on .ifo file, but newer will not, and the color
palette is in .idx file. That mean a .idx with .sub file without a
.ifo file does not mean error, it probably is no problem with current
vobsubs.
Besides, there's function add_subtitles() in mplayer.c, it has a
parameter named 'silent', but never set to non-zero when call this
function. Do you think we should fix the add_subtitles call in line
add_subtitles of r25197 should set silent to 1, or change the
add_subtitles to make the error message could be a warning when
sub_auto is enabled.
A special case is for .sub file, it also be tried to open with
subreader, but it will fail if it's a vobsub .sub file, but it always
print the error message, I don't think it's an error, and the silent
parameter must designed for some usage could it be forget to set
silent?

-- 
Ulion