[MPlayer-cvslog] r25139 - trunk/configure

[Michael Niedermayer]

On Tue, Nov 27, 2007 at 01:59:26AM +0100, Diego Biurrun wrote:
> On Sat, Nov 24, 2007 at 01:17:49PM +0100, Michael Niedermayer wrote:
> > 
> > On Fri, Nov 23, 2007 at 09:37:29PM -0500, Rich Felker wrote:
> > > On Fri, Nov 23, 2007 at 01:39:44PM +0200, Ivan Kalvachev wrote:
> > > > 2007/11/22, diego <subversion at mplayerhq.hu>:
> > > > >
> > > > > Log:
> > > > > Remove ! operator hack, we require a POSIX-compatible-shell.
> > > > 
> > > > I think this is the first time in MPlayer history when we intensionally
> > > > decrease compatibility for no apparent reason.
> > > 
> > > Agree. I oppose this change. [...]
> > 
> > i tend to agree as well ...
> > btw which OS / shells are affected by the change?
> 
> The broken stuff that Solaris ships as default.  I'm not sure if it
> still affects Solaris 10/11, but they have sane shells available.

broken != non posix IMHO


> 
> > if its just some old outdated stuff it probably wont do much harm to
> > remove, OTOH if this means loosing support for some major shell/os it
> > seems like a really stupid change. Also it will be used as argument
> > in favor of auto* if our configure cannot be used on some system where
> > auto* can
> 
> Following that train of thought we should restore support for Visual C++
> compilers in FFmpeg.

no this is very different

to support vc++ we cannot use some type of valid c syntax, not using it would
lead to significantly less readable code
some people submitted patches to add vc++ support they were rejected because
they made the code less readable not because we choose not to support vc++

i think you yourself have even written in the ffmpeg docs that we would
accept a patch which would add vc++ support if it were clean

anyway if all platforms which needed this hack have posix shells available
then ive no objections to removing it, i just wonder why it was added in the
first place ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20071127/59059ae7/attachment.pgp>