[MPlayer-cvslog] r25139 - trunk/configure

Ivan Kalvachev ikalvachev at gmail.com
Sat Nov 24 22:58:20 CET 2007


2007/11/24, Diego Biurrun <diego at biurrun.de>:
> On Fri, Nov 23, 2007 at 01:39:44PM +0200, Ivan Kalvachev wrote:
> > 2007/11/22, diego <subversion at mplayerhq.hu>:
> > >
> > > Log:
> > > Remove ! operator hack, we require a POSIX-compatible-shell.
> >
> > I think this is the first time in MPlayer history when we intensionally
> > decrease compatibility for no apparent reason.
>
> Nonsense, many OS-specific hacks have been removed in the past and will
> be removed in the future, e.g. the removal of loader/loader_objfix.sh.

>From reading the archives I get the impression that removing this hack
is part of patch that brings proper way to handle the issue, as same
problem appears on mac-intel.
( e.g. thread "MPlayer-dev-eng] [PATCH] Windows DLL support for OS
X/Intel (cleaned version)" ).

[,,,]
> > BTW, this hack seems to be introduced by commit 8781,
> > to fix some old Solaris problem. New Solaris should be OK.
>
> Exactly, one less reason to keep this hack that makes configure harder
> to read and maintain.

That's fun. I think some of C/C++ standards introduced "not" keyword
that behaves same way as "!", only because using "not" is easier to
read in expression.
(C90 have iso646.h that defines these alternate punctuation token spellings).
2b|!2b

Anyway, the situation would have been different if "not" evaluation
have been problematic, if it have given different results when used
with weired expressions that would otherwise work with "!". _This_
would have made configure harder to maintain and it would have been
valid reason to drop the hack.



More information about the MPlayer-cvslog mailing list